Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explicitly mention deviations from semver #1689

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

morremeyer
Copy link
Contributor

@morremeyer morremeyer commented Sep 16, 2024

PR Description

This explicitly documents that the versioning scheme is not exactly following semantic versioning, but trying to keep as close as possible to it.

Which issue(s) this PR fixes

Fixes #1675

Notes to the Reviewer

PR Checklist

  • Documentation added

Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine by me, waiting for @clayton-cornell input

Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise it's fine :-)

docs/sources/introduction/backward-compatibility.md Outdated Show resolved Hide resolved
docs/sources/introduction/backward-compatibility.md Outdated Show resolved Hide resolved
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Sep 17, 2024
@clayton-cornell
Copy link
Contributor

Thanks for this change @morremeyer Getting this change merged and backported today.

@clayton-cornell clayton-cornell merged commit ba348ea into grafana:main Sep 18, 2024
19 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 18, 2024
Co-authored-by: William Dumont <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit ba348ea)
github-actions bot pushed a commit that referenced this pull request Sep 18, 2024
Co-authored-by: William Dumont <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit ba348ea)
github-actions bot pushed a commit that referenced this pull request Sep 18, 2024
Co-authored-by: William Dumont <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit ba348ea)
github-actions bot pushed a commit that referenced this pull request Sep 18, 2024
Co-authored-by: William Dumont <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit ba348ea)
@morremeyer morremeyer deleted the docs/versioning branch September 19, 2024 08:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.4.0-rc.0 contains breaking changes
3 participants