Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump yet-another-cloudwatch-exporter to v0.61.0 #1690

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

morremeyer
Copy link
Contributor

PR Description

This bumps yet-another-cloudwatch-exporter to v0.61.0, which fixes an issue with S3 metrics being reported as NaN.

Affected metrics have a value of 0 in the scraped prometheus metrics. With the update to v0.61.0, they are reported correctly.

Which issue(s) this PR fixes

None

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated

@morremeyer morremeyer marked this pull request as ready for review September 16, 2024 09:21
@morremeyer morremeyer requested a review from a team as a code owner September 16, 2024 09:21
@morremeyer morremeyer marked this pull request as draft September 16, 2024 11:27
@morremeyer
Copy link
Contributor Author

morremeyer commented Sep 16, 2024

The JobLevelMetricFields field has been removed with nerdswords/yet-another-cloudwatch-exporter#1412, it is now always on the metric level and not configurable for a job anymore.

Therefore, I'm removing it from the tests with be6a2c1 and ad78ebd.

@morremeyer morremeyer marked this pull request as ready for review September 16, 2024 13:08
Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@wildum
Copy link
Contributor

wildum commented Sep 17, 2024

@morremeyer could you please rebase your branch with main?

This bumps yet-another-cloudwatch-exporter to v0.61.0, which fixes [an issue with S3 metrics being reported as `NaN`](nerdswords/yet-another-cloudwatch-exporter#728).

Affected metrics have a value of `0` in the scraped prometheus metrics. With the update to v0.61.0, they are reported correctly.
@morremeyer
Copy link
Contributor Author

@wildum Done, thanks for the review!

@wildum wildum merged commit 1881ae4 into grafana:main Sep 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] S3 bucket metrics are AWS 'region' dependent "NaN"
2 participants