Remove Pyroscope scrape loops for no longer active targets #1833
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildum
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
There is a bug which causes pyroscope.scrape to keep trying to scrape targets even if they're no longer active. We can also see error logs in internal clusters, but we hadn't noticed them before.
Credits in the changelog go to @mattdurham, @wildum, and @dehaansa. We have a squad meeting once every few weeks for bug fixing and socializing. We chose this bug for today's meeting, so I'm adding all the folks from the meeting to the changelog :)
Which issue(s) this PR fixes
Fixes #1789
PR Checklist