-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(otelcol/exporter/datadog) Add Datadog exporter wrapper #739
Conversation
7e11654
to
e4f3d61
Compare
This PR has not had any activity in the past 30 days, so the |
17673c6
to
0c05bfd
Compare
@wildum I've tested this locally and it works. I'll get onto some documentation tomorrow, but can you look over the code as it is now so I can get some feedback? I need to update the tests to acknowledge the new defaults for the config still as well 😅 |
f284ad8
to
713da2b
Compare
f9ae25a
to
06437a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! I reviewed only the code without checking the defaults and left a few comments. We will also need a config converter for this component (see https://github.com/grafana/alloy/tree/main/internal/converter/internal/otelcolconvert).
Can't wait for Alloy to get its first community component :)
06437a6
to
93dcc3c
Compare
93dcc3c
to
20eccc9
Compare
I've addressed the PR comments and rebased on main, testing locally seems to be working 👍 @wildum can I get another look? I'll add the config converter now |
Still an issue where endpoint is required, we could make a custom type but that feels a bit too much
docs/sources/reference/components/otelcol/otelcol.exporter.datadog.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.datadog.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.datadog.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.datadog.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.datadog.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.datadog.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.datadog.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.datadog.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.datadog.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.datadog.md
Outdated
Show resolved
Hide resolved
Apply doc updates from review Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did another round of review. Good job and thanks for all the efforts. The config for this component is crazy but we are getting close to get it ready!
internal/component/otelcol/exporter/datadog/config/config_datadog.go
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.datadog.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.datadog.md
Outdated
Show resolved
Hide resolved
Co-authored-by: William Dumont <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some additional doc suggestions:
- Add the community component shared content at the top of the doc
- Tidy up the table formatting
- Remove some extra empty lines and spaces
- Some other minor syntax/layout suggestions
docs/sources/reference/components/otelcol/otelcol.exporter.datadog.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.datadog.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.datadog.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.datadog.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.datadog.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.datadog.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.datadog.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.datadog.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.datadog.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some additional doc suggestions:
- Add the community component shared content at the top of the doc
- Tidy up the table formatting
- Remove some extra empty lines and spaces
- Some other minor syntax/layout suggestions
Co-authored-by: Clayton Cornell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs look OK, Approving for docs. If anything else comes up for docs, we can catch it in a new PR :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work, we are proud to welcome our first community component contributor!
PR Description
This PR adds a wrapper around the Datadog Exporter from the opentelemetry-collector-contrib repo. It enables use of the Datadog exporter, which allows Alloy to send telemetry (metrics and traces at this point) to Datadog.
This is useful in migrating a Datadog setup towards a more OSS architecture. By allowing Alloy to talk to Datadog, Alloy can serve a new wedge of users using this proprietary platform and embrace OTel more.
Documentation and more tests need to be added, as well as more scrutiny; I intend on continuing work on this branch to address these over the next few days. This MR has dependency on #711 , hence the large diff 😅
Which issue(s) this PR fixes
Fixes #714
Notes to the Reviewer
PR Checklist