Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Go to 1.22.3 #788

Merged
merged 2 commits into from
May 8, 2024
Merged

Upgrade Go to 1.22.3 #788

merged 2 commits into from
May 8, 2024

Conversation

kminehart
Copy link
Contributor

@kminehart kminehart commented May 7, 2024

PR Description

Upgrades Go to 1.22.3

Which issue(s) this PR fixes

#787

Notes to the Reviewer

This is unfortunately not functional until this process to build the Microsoft fork / docker image is successful: microsoft/go#1218

As soon as I opened the PR the status is ✅!

Looks like it's waiting for some manual intervention before moving on to the next step so we will have to wait for that.

PR Checklist

I did not see other references in the changelog to dependency updates so I have removed that line.

  • Tests updated

Thanks!!

@kminehart kminehart added go Pull requests that update Go code outdated-dependency Related to an outdated dependency. labels May 7, 2024
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little surprised everything in the Drone workflow succeeded because it's still using the old 1.22 version (from grafana/alloy-build-image:v0.1.0).

I'll create grafana/alloy-build-image:v0.1.1 after this is merged, but then there will need to be a second PR to use that image.

@rfratto rfratto merged commit 6506759 into grafana:main May 8, 2024
21 checks passed
@rfratto rfratto added backport release/v1.1 backport-to-agent PR should be backported to the agent repo. labels May 8, 2024
github-actions bot pushed a commit that referenced this pull request May 8, 2024
* Upgrade Go to 1.22.3

* Sign .drone.yml

(cherry picked from commit 6506759)
rfratto pushed a commit that referenced this pull request May 8, 2024
* Upgrade Go to 1.22.3

* Sign .drone.yml

(cherry picked from commit 6506759)

Co-authored-by: Kevin Minehart <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport release/v1.1 backport-to-agent PR should be backported to the agent repo. frozen-due-to-age go Pull requests that update Go code outdated-dependency Related to an outdated dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants