Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close procRoot dir #891

Merged
merged 1 commit into from
Aug 22, 2024
Merged

fix: close procRoot dir #891

merged 1 commit into from
Aug 22, 2024

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine commented May 21, 2024

This fix was originally suggested in grafana/agent#6906. Sot it is a forward port.

@simonswine simonswine marked this pull request as ready for review May 24, 2024 09:35
Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@simonswine simonswine force-pushed the 20240521_fix-close-procRoot-dir branch from 0042085 to c1d60c2 Compare August 21, 2024 13:24
@simonswine
Copy link
Contributor Author

Just rebase, a review would be appreciated

@simonswine simonswine merged commit db4712f into main Aug 22, 2024
18 checks passed
@simonswine simonswine deleted the 20240521_fix-close-procRoot-dir branch August 22, 2024 16:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants