Skip to content

Commit

Permalink
Don't run 'devbox run' in a loop in the CI
Browse files Browse the repository at this point in the history
  • Loading branch information
K-Phoen committed Sep 27, 2024
1 parent f347a70 commit 6e9b1fa
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 20 deletions.
27 changes: 7 additions & 20 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,18 +61,10 @@ jobs:
--parameters output_dir=./generated/%l,grafana_version=${{ matrix.kind_version == 'next' && 'main' || matrix.kind_version }},kind_registry_version=${{ matrix.kind_version }},go_package_root=github.com/grafana/cog/generated/go
- name: Compile generated Go code
run: |
for d in generated/go/*/ ; do
echo "Building $d"
devbox run go build "./$d"
done
run: ./scripts/ci/build-go.sh

- name: Compile generated Typescript code
run: |
for d in generated/typescript/src/*/ ; do
echo "Building $d"
devbox run ts-node "./$d"
done
run: ./scripts/ci/build-ts.sh

- name: Lint generated Python code
run: devbox run mypy generated/python/
Expand Down Expand Up @@ -102,21 +94,16 @@ jobs:
run: git clone --depth=1 https://github.com/grafana/kind-registry.git ../kind-registry

- name: Run code generation
run: |
make gen-sdk-dev
run: make gen-sdk-dev

- name: Run the Go example
run: |
make run-go-example
run: make run-go-example

- name: Run the Typescript example
run: |
make run-ts-example
run: make run-ts-example

- name: Run the PHP example
run: |
make run-php-example
run: make run-php-example

- name: Run Java example
run: |
make run-java-example
run: make run-java-example
15 changes: 15 additions & 0 deletions scripts/ci/build-go.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
#!/usr/bin/env bash

# Exit on error. Append "|| true" if you expect an error.
set -o errexit
# Exit on error inside any functions or subshells.
set -o errtrace
# Do not allow use of undefined vars. Use ${VAR:-} to use an undefined VAR
set -o nounset
# Catch the error in case mysqldump fails (but gzip succeeds) in `mysqldump |gzip`
set -o pipefail

for d in generated/go/*/ ; do
echo "Building $d"
go build "./$d"
done
15 changes: 15 additions & 0 deletions scripts/ci/build-ts.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
#!/usr/bin/env bash

# Exit on error. Append "|| true" if you expect an error.
set -o errexit
# Exit on error inside any functions or subshells.
set -o errtrace
# Do not allow use of undefined vars. Use ${VAR:-} to use an undefined VAR
set -o nounset
# Catch the error in case mysqldump fails (but gzip succeeds) in `mysqldump |gzip`
set -o pipefail

for d in generated/typescript/src/*/ ; do
echo "Building $d"
devbox run ts-node "./$d"
done

0 comments on commit 6e9b1fa

Please sign in to comment.