Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial tests coverage for golang jenny #16

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

K-Phoen
Copy link
Member

@K-Phoen K-Phoen commented Sep 12, 2023

Similar to #13, but for Go.

Things to notice:

  • I run the compiler passes for Go before running the raw types jenny. This is because the IR supports some concepts that don't translate directly into Go (disjunctions, in particular).
  • the Go output isn't properly formatted: it's expected, that's the job of a post-processor
  • disjunctions aren't properly handled. In their current form, most of them can't properly be marshaled to/unmarshaled from JSON. It's a leftover from the PoC days and since it's not trivial to fix/finish, it will be done in another PR and is tracked by a different issue.
  • there are some places in the code that should never be reached ©, but no error would bubble up if we reached them. The error handling should definitely be improved in another PR (see Improve Go RawTypes jenny error handling #18).

Related to #6

@K-Phoen K-Phoen requested a review from a team as a code owner September 12, 2023 21:55
Base automatically changed from ts-types-jenny-tests to main September 18, 2023 22:19
Copy link
Member

@spinillos spinillos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like fine.

@K-Phoen K-Phoen merged commit 548f2b9 into main Sep 19, 2023
2 checks passed
@K-Phoen K-Phoen deleted the go-types-jenny-tests branch September 19, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants