Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement proper support for scalar or "discriminated" disjunctions in Go jenny #19

Merged
merged 17 commits into from
Sep 21, 2023
Merged

Implement proper support for scalar or "discriminated" disjunctions in Go jenny #19

merged 17 commits into from
Sep 21, 2023

Commits on Sep 19, 2023

  1. Implement proper support for scalar+array only disjunctions in Go jenny

    @K-Phoen
    K-Phoen committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    919bc3b View commit details
    Browse the repository at this point in the history

  2. First pass at implementing generic support for disjunction of referen… 

    …ces (still WIP)
    @K-Phoen
    K-Phoen committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    bc8a7d1 View commit details
    Browse the repository at this point in the history

  3. Disable an annoying linting rule

    @K-Phoen
    K-Phoen committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    f63669d View commit details
    Browse the repository at this point in the history

  4. Return an error when unmarshaling a disjunction with unexpected discr… 

    …iminator value
    @K-Phoen
    K-Phoen committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    1307604 View commit details
    Browse the repository at this point in the history

  5. Return errors when something goes wrong while handling a disjunction

    @K-Phoen
    K-Phoen committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    84c41f2 View commit details
    Browse the repository at this point in the history

  6. More defensive checks when building a discriminator mapping

    @K-Phoen
    K-Phoen committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    517b67d View commit details
    Browse the repository at this point in the history

  7. Little code cleanup

    @K-Phoen
    K-Phoen committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    9462a98 View commit details
    Browse the repository at this point in the history

  8. Little cosmetic rearrangement

    @K-Phoen
    K-Phoen committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    57760be View commit details
    Browse the repository at this point in the history

  9. Update a couple of txtar tests outputs

    @K-Phoen
    K-Phoen committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    c2c4063 View commit details
    Browse the repository at this point in the history

  10. Write a few unit tests for disjunctions of scalars

    @K-Phoen
    K-Phoen committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    e99c8d1 View commit details
    Browse the repository at this point in the history

  11. Write a few unit tests for disjunctions of refs

    @K-Phoen
    K-Phoen committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    c7b2fd9 View commit details
    Browse the repository at this point in the history

  12. Update a few comments

    @K-Phoen
    K-Phoen committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    0d72d26 View commit details
    Browse the repository at this point in the history

  13. Finish Types.HasOnlyScalarOrArray() implementation

    @K-Phoen
    K-Phoen committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    9c1f79a View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Properly handle required/nullable types and fields

    @K-Phoen
    K-Phoen committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    581cfea View commit details
    Browse the repository at this point in the history

  2. Use some syntactic sugar on disjunction unit tests

    @K-Phoen
    K-Phoen committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    7129109 View commit details
    Browse the repository at this point in the history

  3. Add a couple of unit tests for type | null disjunctions handling in… 

    … the `DisjunctionToType` compiler pass
    @K-Phoen
    K-Phoen committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    99b8591 View commit details
    Browse the repository at this point in the history

  4. Handle disjunctions defined in a map value type

    @K-Phoen
    K-Phoen committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    0d1e455 View commit details
    Browse the repository at this point in the history