Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ast.File to ast.Schema and ast.File.Definitions to ast.Schema.Objects #46

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

K-Phoen
Copy link
Member

@K-Phoen K-Phoen commented Oct 3, 2023

Nothing new or fixed here, just some renaming to be more consistent :)

@K-Phoen K-Phoen requested a review from a team as a code owner October 3, 2023 13:30
@@ -323,39 +323,39 @@ func (object Object) DeepCopy() Object {
return newObject
}

type Files []*File
type Schemas []*Schema
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been renamed.

type File struct { //nolint: musttag
Package string
Definitions []Object
type Schema struct { //nolint: musttag
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been renamed.

Definitions []Object
type Schema struct { //nolint: musttag
Package string
Objects []Object
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been renamed.

@K-Phoen K-Phoen merged commit c853b40 into main Oct 5, 2023
2 checks passed
@K-Phoen K-Phoen deleted the schema-type branch October 5, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants