-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap JSON → code conversion in Go #566
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: in addition to the changes introduced by this PR, the diff includes unreleased changes living in
grafana-foundation-sdk@next+cog-v0.0.x |
K-Phoen
force-pushed
the
code-from-json/go-baseline
branch
from
September 27, 2024 22:48
59f3c6b
to
63a74ea
Compare
…nly simple case for now: scalars)
K-Phoen
force-pushed
the
code-from-json/go-baseline
branch
from
September 28, 2024 01:05
f947082
to
5423051
Compare
spinillos
reviewed
Sep 30, 2024
@@ -514,6 +514,10 @@ func NewObject(pkg string, name string, objectType Type, passesTrail ...string) | |||
} | |||
} | |||
|
|||
func (object *Object) AsRef() Type { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AsRef
looks like that I'm expecting a Ref
, not the Type
.
spinillos
approved these changes
Sep 30, 2024
This was referenced Sep 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #314
This PR lays the foundation to convert JSON to code, starting with an implementation in Go.
There are still more things to do:
Editable()
on dashboardInstant()
on prometheus queries