Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When generating YAML resources for kubernetes, only some of them have correct namespace set #177

Open
pstibrany opened this issue Sep 4, 2020 · 2 comments · May be fixed by #178
Open

When generating YAML resources for kubernetes, only some of them have correct namespace set #177

pstibrany opened this issue Sep 4, 2020 · 2 comments · May be fixed by #178

Comments

@pstibrany
Copy link
Member

Only ingester (blocks), store-gateway and compactor have configured namespace. Other resources don't.
@RyanW8
Copy link

RyanW8 commented Sep 4, 2020

More specifically, these resources have the default namespace

➜  cortex-tanka grep -rnw './manifests' -e 'namespace: default'
./manifests/apps-v1.Deployment-distributor.yaml:5:  namespace: default
./manifests/apps-v1.Deployment-query-frontend.yaml:5:  namespace: default
./manifests/v1.Service-store-gateway.yaml:7:  namespace: default
./manifests/policy-v1beta1.PodDisruptionBudget-store-gateway-pdb.yaml:7:  namespace: default
./manifests/policy-v1beta1.PodDisruptionBudget-ingester-pdb.yaml:7:  namespace: default
./manifests/v1.Service-distributor.yaml:7:  namespace: default
./manifests/apps-v1.StatefulSet-memcached.yaml:5:  namespace: default
./manifests/v1.Service-memcached-index-queries.yaml:7:  namespace: default
./manifests/apps-v1.Deployment-querier.yaml:5:  namespace: default
./manifests/v1.Service-memcached.yaml:7:  namespace: default
./manifests/v1.ConfigMap-overrides.yaml:8:  namespace: default
./manifests/apps-v1.StatefulSet-memcached-index-queries.yaml:5:  namespace: default
./manifests/v1.Service-memcached-frontend.yaml:7:  namespace: default
./manifests/v1.ConfigMap-schema-fa9497f5acccafcc3e6019657bdc5eb1.yaml:8:  namespace: default
./manifests/v1.Service-query-frontend.yaml:7:  namespace: default
./manifests/apps-v1.StatefulSet-memcached-frontend.yaml:5:  namespace: default
./manifests/v1.Service-memcached-metadata.yaml:7:  namespace: default
./manifests/apps-v1.StatefulSet-memcached-metadata.yaml:5:  namespace: default
./manifests/v1.Service-querier.yaml:7:  namespace: default
./manifests/v1.Service-query-frontend-discovery.yaml:7:  namespace: default
./manifests/v1.Service-ingester.yaml:7:  namespace: default

@RyanW8 RyanW8 linked a pull request Sep 4, 2020 that will close this issue
Open
1 task
@jdbaldry
Copy link
Member

In my opinion, we should omit namespaces from all resources if we can as kubectl/tanka can add them in if required. If we still want _config.namespace, I'd be tempted to make values that use it handle a null value so that users can opt out if desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure namespace is set on all Kubernetes resources
3 participants
@pstibrany @jdbaldry @RyanW8