Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure namespace is set on all Kubernetes resources #178

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Ensure namespace is set on all Kubernetes resources #178

wants to merge 5 commits into from

Conversation

RyanW8
Copy link

@RyanW8 RyanW8 commented Sep 4, 2020

What this PR does:

Ensure the namespace defined in _config is set on these resources:

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Ryan added 2 commits September 4, 2020 13:11
…ng resources:

- Distributor
- Memcached
- Querier
- Query-frontend
@RyanW8 RyanW8 requested a review from a team as a code owner September 4, 2020 12:14
Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RyanW8 RyanW8 requested a review from jtlisi September 4, 2020 15:12
@RyanW8
Copy link
Author

RyanW8 commented Sep 4, 2020

Fixed conflicts. Can you please merge?

Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start, but some resources are still missing namespace.

@@ -7,6 +7,8 @@
* [CHANGE] Add overrides config to tsdb store-gateway. #167
* [CHANGE] Ingesters now default to running as `StatefulSet` with WAL enabled. It is controlled by the config `$._config.ingester_deployment_without_wal` which is `false` by default. Setting the config to `true` will yeild the old behaviour (stateless `Deployment` without WAL enabled). #72
* [CHANGE] We now allow queries that are 32 days long. For example, rate(metric[32d]). Before it was 31d. #173
* [BUGFIX] Add support the `local` ruler client type
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be here -- it's already on top.

CHANGELOG.md Outdated Show resolved Hide resolved
@pstibrany
Copy link
Member

Branch https://github.com/grafana/cortex-jsonnet/tree/pull/178 shows how to add namespaces to more (but still not all) resources.

Co-authored-by: Peter Štibraný <[email protected]>
Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

Base automatically changed from master to main March 3, 2021 14:44
@CLAassistant
Copy link

CLAassistant commented Jun 15, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Ryan
❌ RyanW8


Ryan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When generating YAML resources for kubernetes, only some of them have correct namespace set
4 participants