Skip to content

Commit

Permalink
Create CI/CD test and build in the Github action (#523)
Browse files Browse the repository at this point in the history
* Create test build in github action

Signed-off-by: Jon Kartago Lamida <[email protected]>

* Fix job invalid job name

Signed-off-by: Jon Kartago Lamida <[email protected]>

* Use listen port 8080 due to issue in github action

Signed-off-by: Jon Kartago Lamida <[email protected]>

* Run github action only on push to main

Signed-off-by: Jon Kartago Lamida <[email protected]>

* Update check-protos step

Signed-off-by: Jon Kartago Lamida <[email protected]>

* Use go-version matrix

Signed-off-by: Jon Kartago Lamida <[email protected]>

* Fix yaml

Signed-off-by: Jon Kartago Lamida <[email protected]>

* Revert accidentally unintended commits

Signed-off-by: Jon Kartago Lamida <[email protected]>

* Apply PR feedbacks

Signed-off-by: Jon Kartago Lamida <[email protected]>

* Capitalise workflow name

Signed-off-by: Jon Kartago Lamida <[email protected]>

* Can't use template in the job name

Signed-off-by: Jon Kartago Lamida <[email protected]>

* Revert to original job id

Signed-off-by: Jon Kartago Lamida <[email protected]>

* Use better job name description

Signed-off-by: Jon Kartago Lamida <[email protected]>

* Fix step name

Signed-off-by: Jon Kartago Lamida <[email protected]>

* Remove redundant step name

Signed-off-by: Jon Kartago Lamida <[email protected]>

* Simplify the step name again

Signed-off-by: Jon Kartago Lamida <[email protected]>

* Update server/server_test.go

Co-authored-by: Charles Korn <[email protected]>

* Use separate job for go test 1.20.x

Signed-off-by: Jon Kartago Lamida <[email protected]>

* Separate job for test and the rest

Signed-off-by: Jon Kartago Lamida <[email protected]>

* Update .github/workflows/test-build.yml

Co-authored-by: Charles Korn <[email protected]>

* Apply more PR feedbacks

Signed-off-by: Jon Kartago Lamida <[email protected]>

---------

Signed-off-by: Jon Kartago Lamida <[email protected]>
Co-authored-by: Charles Korn <[email protected]>
  • Loading branch information
lamida and charleskorn authored May 15, 2024
1 parent a1bba12 commit ab41af5
Show file tree
Hide file tree
Showing 2 changed files with 56 additions and 0 deletions.
54 changes: 54 additions & 0 deletions .github/workflows/test-build.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
name: CI
on:
push:
branches:
- main
pull_request:

concurrency:
# Cancel any running workflow for the same branch when new commits are pushed.
# We group both by ref_name (available when CI is triggered by a push to a branch/tag)
# and head_ref (available when CI is triggered by a PR).
group: "${{ github.ref_name }}-${{ github.head_ref }}"
cancel-in-progress: true

jobs:
check:
name: Check
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: '1.21.x'
- name: Go mod check
run: make mod-check
- name: Lint
run: make lint
- name: Test benchmarks
run: make test-benchmarks
- name: Check protos
run: |
apt-get update && apt-get -y install unzip
go mod vendor
make check-protos
test:
name: Test on Go ${{ matrix.go-version }}
runs-on: ubuntu-latest
strategy:
matrix:
# We want to make sure dskit can support multiple golang versions
# by ensuring the test would pass using all these supported versions.
go-version: ['1.20.x', '1.21.x']
steps:
- uses: actions/checkout@v4
- name: Set up Go ${{ matrix.go-version }}
uses: actions/setup-go@v5
with:
go-version: ${{ matrix.go-version }}
- name: Display Go version
run: go version
- name: Test
run: make test
2 changes: 2 additions & 0 deletions server/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -949,6 +949,8 @@ func TestGrpcOverProxyProtocol(t *testing.T) {
var cfg Config
cfg.RegisterFlags(flag.NewFlagSet("", flag.ExitOnError))
cfg.ProxyProtocolEnabled = true
// Set this to 0 to have it choose a random port
cfg.HTTPListenPort = 0

fakeSourceIP := "1.2.3.4"

Expand Down

0 comments on commit ab41af5

Please sign in to comment.