Fix all flaky tests #600
Merged
Fix all flaky tests #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `TestPartitionInstanceLifecycler`: Increase test polling timeout. 1s seems tight, it fails with `-race`. Fixes #572 - `TestBasicLifecycler_HeartbeatWhileRunning`: Same as above - `TestRejoin`: Converted the test to use `require.Eventually` instead of a custom func + increased polling timeout a bit - `TestTLSServerWithLocalhostCertWithClientCertificateEnforcementUsingClientCA1`: Wait until the server is ready before running tests
julienduchesne
force-pushed
the
julienduchesne/fix-partition-flaky
branch
from
1625ab3
to
a6ad4d0
Compare
julienduchesne
changed the title
TestPartitionInstanceLifecycler
|
/find-flaky-tests Run: https://github.com/grafana/dskit/actions/runs/11242094613 |
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestPartitionInstanceLifecycler: Increase test polling timeout. 1s seems tight, as it sometimes fails with-race. Fixes Flaky testTestPartitionInstanceLifecycler#572TestBasicLifecycler_HeartbeatWhileRunning: Same as aboveTestRejoin: Converted the test to userequire.Eventuallyinstead of a custom func + increased polling timeout a bitTestTLSServerWithLocalhostCertWithClientCertificateEnforcementUsingClientCA1: Wait until the server is ready before running testsMostly increasing timeouts, but I believe
-raceis making those tests fail. Can't rely on time working correctly