Really fix flaky TestMultipleClients tests
#603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienduchesne
force-pushed
the
julienduchesne/really-fix-member-tests
branch
from
63a41b2
to
27414ec
Compare
#599 went in a wrong direction, so I revert it here: it makes all `TestMultipleClients` tests flaky since not all members are necessarily joined after the updates Instead, to fix the `TestMultipleClientsWithMixedLabelsAndExpectFailure` test, I add a couple more labeled members, that way, even if we reach 3 updates (which happened some times), we'll never get to 5 with a single member Also, try to fix the `TestTLSServerWithLocalhostCertWithClientCertificateEnforcementUsingClientCA1` test by closing GRPC connections. Maybe this (golang/go#36700) is the issue?
julienduchesne
force-pushed
the
julienduchesne/really-fix-member-tests
branch
from
27414ec
to
42fcc5d
Compare
julienduchesne
force-pushed
the
julienduchesne/really-fix-member-tests
branch
2 times, most recently
from
79ff135
to
5d8c8e8
Compare
julienduchesne
force-pushed
the
julienduchesne/really-fix-member-tests
branch
from
5d8c8e8
to
3d87265
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#599 went in a wrong direction, so I revert it here: it makes all
TestMultipleClientstests flaky since not all members are necessarily joined after the updatesInstead, to fix the
TestMultipleClientsWithMixedLabelsAndExpectFailuretest, I add a couple more labeled members, that way, even if we reach 3 updates (which happened some times, hence the flakes), we'll never get to 5 with a single memberAlso, try to fix the
TestTLSServerWithLocalhostCertWithClientCertificateEnforcementUsingClientCA1test by re-doing requests that have been reset by the server, but only if we were expecting an error. Note that this is not newly flaky, this comment has been there since the beginning:dskit/crypto/tls/test/tls_integration_test.go
Lines 381 to 383 in 2e104a8
Flaky tests run: https://github.com/grafana/dskit/actions/runs/11257895128 🟢