Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ring: working example on using ring package #272

Merged
merged 19 commits into from
Aug 3, 2023
Merged

Conversation

kavirajk
Copy link
Contributor

@kavirajk kavirajk commented Feb 28, 2023

What this PR does:
An example to show case the usage of ring package. We build a small cluster of process using local "loopback" interface.

Going forward I wanted to add another example to use it with k8.

Which issue(s) this PR fixes:

Related: #267

Checklist

  • Tests updated
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@kavirajk kavirajk marked this pull request as ready for review February 28, 2023 20:19
@kavirajk kavirajk requested a review from pstibrany March 1, 2023 09:41
@fgouteroux
Copy link

@kavirajk thanks a lot for this usefull example. It help me a lot.

Copy link
Collaborator

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments, mainly the ones for ring/example/local/README.md :)

ring/example/local/README.md Outdated Show resolved Hide resolved
ring/example/local/README.md Outdated Show resolved Hide resolved
ring/example/local/README.md Outdated Show resolved Hide resolved
ring/example/local/README.md Outdated Show resolved Hide resolved
ring/example/local/README.md Outdated Show resolved Hide resolved
ring/example/local/local.go Outdated Show resolved Hide resolved
ring/example/local/local.go Outdated Show resolved Hide resolved
ring/example/local/local.go Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
ring/example/local/go.mod Show resolved Hide resolved
Copy link
Collaborator

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please see nits. Also the build needs fixing :)

Signed-off-by: Kaviraj <[email protected]>
Signed-off-by: Kaviraj <[email protected]>
@kavirajk kavirajk merged commit 71537ce into main Aug 3, 2023
@kavirajk kavirajk deleted the kavirajk/ring-examples branch August 3, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants