Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add concurrency to the memberlist transport's WriteTo method #525

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Add concurrency to the memberlist transport's WriteTo method #525

merged 5 commits into from
Oct 10, 2024

Commits on Oct 10, 2024

  1. make WriteTo non-blocking

    @aldernero @julienduchesne
    aldernero authored and julienduchesne committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    c55eded View commit details
    Browse the repository at this point in the history

  2. Try to make this PR ready to go 

    - Create goroutines and keep them while the TCPTransport is alive. End them on the `Shutdown` function
- Add `TestTCPTransportWriteToUnreachableAddr` test to check that writing is not blocking anymore (without this PR, it takes `writeCt * timeout` to run and it fails)
    @julienduchesne
    julienduchesne committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    516a2ce View commit details
    Browse the repository at this point in the history

  3. Add CHANGELOG

    @julienduchesne
    julienduchesne committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    d88e163 View commit details
    Browse the repository at this point in the history

  4. Address PR comments 

    - Rename CHANGELOG
- Mutex lock on shutdown rather than write
- Wait when workers are ended rather than for each write
    @julienduchesne
    julienduchesne committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    95d45b3 View commit details
    Browse the repository at this point in the history

  5. Address PR comments 

    - Move variables around
- Add timeout before dropping requests. This prevents blocking on the `WriteTo` function
    @julienduchesne
    julienduchesne committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ecd4853 View commit details
    Browse the repository at this point in the history