httpgrpc Server can now use message from HTTP header when converting HTTP response to error #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting HTTP response to error.
aknuds1
approved these changes
Jun 13, 2024
Thanks for review, I've addressed your feedback in 4330714 |
pstibrany
added a commit
that referenced
this pull request
Jun 13, 2024
…HTTP response to error (#531) * httpgrpc Server can now use error message from the header when converting HTTP response to error. * CHANGELOG.md * Make linter happy. * Address review feedback.
pstibrany
added a commit
that referenced
this pull request
Jun 13, 2024
* httpgrpc Server can now use message from HTTP header when converting HTTP response to error (#531)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
httpgrpc Server (implementation of
httpgrpc.HTTPgRPC service) converts HTTP responses to errors under certain conditions. In this conversion it uses HTTP response body as an error message. If HTTP response body is not a valid UTF-8 string, then such converted error will not be protobuf-marshalable anymore.This PR adds option to supply alternative error message for such conversion by setting special HTTP header, that is recognized by httpgrpc Server.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]