Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum go version to 1.21 #540

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Update minimum go version to 1.21 #540

merged 2 commits into from
Jul 4, 2024

Conversation

pracucci
Copy link
Contributor

@pracucci pracucci commented Jul 3, 2024

What this PR does:

In dskit we aim to keep support for the last 2 stable go version. Currently dskit requires 1.20. I propose to upgrade the requirement to 1.21. In this PR I'm also updating drone to run CI against latest 1.21 minor release.

Which issue(s) this PR fixes:

N/A

Checklist

  • Tests updated
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Marco Pracucci <[email protected]>
@pracucci pracucci marked this pull request as draft July 3, 2024 16:39
@pracucci pracucci mentioned this pull request Jul 3, 2024
2 tasks
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@pracucci pracucci marked this pull request as ready for review July 4, 2024 07:34
@pracucci
Copy link
Contributor Author

pracucci commented Jul 4, 2024

Merging cause I think this is non controversial.

@pracucci pracucci merged commit cef0e39 into main Jul 4, 2024
6 checks passed
@pracucci pracucci deleted the require-golang-1.21 branch July 4, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants