Fix flaky memberlist TestRejoin test
#598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienduchesne
changed the title
TestRejoin test
pstibrany
reviewed
Oct 8, 2024
julienduchesne
force-pushed
the
julienduchesne/fix-flaky-memberlist-tests
branch
from
de540a5
to
5fcdcb9
Compare
|
/find-flaky-tests Run: https://github.com/grafana/dskit/actions/runs/11236767195 (lots of cancels, the |
pstibrany
approved these changes
Oct 8, 2024
julienduchesne
added a commit
that referenced
this pull request
Oct 8, 2024
This failed in a bunch of runs in #598 When it fails, it has 3 updates, but they're all from the same member. I believe what we want to check is that the cluster never gets joined by members with labels
julienduchesne
added a commit
that referenced
this pull request
Oct 8, 2024
This failed in a bunch of runs in #598 When it fails, it has 3 updates, but they're all from the same member. I believe what we want to check is that the cluster never gets joined by members with labels
julienduchesne
added a commit
that referenced
this pull request
Oct 8, 2024
This failed in a bunch of runs in #598 When it fails, it has 3 updates, but they're all from the same member. I believe what we want to check is that the cluster never gets joined by members with labels
julienduchesne
added a commit
that referenced
this pull request
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It randomly failed here: #525 and in some of the test runs here: #596
This test fails due to the probe interval being 5s, which is the same time we poll for