TestMultipleClients*: Poll for the memberlist status for 10 seconds
#608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #389 These tests are highly dependant on timing, which makes them flaky. Poll for a bit longer at the end to make sure that the memberlist was updated
julienduchesne
force-pushed
the
julienduchesne/memberlist-test-poll
branch
from
5c302c0
to
2493afc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flaky test run: https://github.com/grafana/dskit/actions/runs/11281170696
Closes #389
These tests are highly dependant on timing, which makes them flaky. For example, they don't fail on my machine unless I cut down the initial update time a bit, but they seem to fail often on Github Actions. I think this is due to machine power.
Solution: Poll for a bit longer at the end to make sure that the memberlist was updated