-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update grafana.ini.j2 #203
Conversation
Changed the legacy setting `[alerting]` to `[unified_alerting]`. Grafana-server will not start with the legacy setting enabled.
I think it would be good to rename the variable |
I agree--for consistency. However, if I'm not mistaken, this is lower level. This is a section header in Grafana.ini so changing variable alone will not fix the error. If version selection allows a numerical version, it might be better to use a tag with a ternary to select the correct section header. |
I quite like how the grafana helm chart automatically converts yaml to grafana.ini Example config: https://github.com/grafana/helm-charts/blob/main/charts/grafana/values.yaml#L772-L1098 grafana.ini:
alerting:
enabled: true becomes [alerting]
enabled = true Should be doable for ansible too. Maybe should be a separate issue tho. |
Created separate issue #210 for my suggestion above. |
Version selection makes sense for backward compatibility, which I like. Could you implement this and update the PR? |
Changed the legacy setting
[alerting]
to[unified_alerting]
. Grafana-server will not start with the legacy setting enabled.