add grafana_plugins_ops to defaults and docs #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@gardar @ishanjainn any chance you could have a look please? |
weakcamel
force-pushed
the
grafana_plugins_ops
branch
from
b34b7d6
to
e3870aa
Compare
ishanjainn
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A configuration variable
grafana_plugins_opshas been added in #88 PR (ingrafana.initemplate). This value wasn't however added to the documentation nor defaults which this PR attempts to rectify.For. consistency with all other configuration sections I've changed the template slightly. In most cases it should have the identical result (section included when expected dictionary is not empty) but it is a subtle interface change. If preserving the exact behaviour is the key, changing the default value to
Noneshould do the trick.