Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't use PropsWithChildren since we already specify a children type #130

Merged
merged 1 commit into from
Oct 2, 2024
Merged

don't use PropsWithChildren since we already specify a children type #130

merged 1 commit into from
Oct 2, 2024

Conversation

ashharrison90
Copy link
Contributor

@ashharrison90 ashharrison90 self-assigned this Oct 1, 2024
@ashharrison90 ashharrison90 requested a review from a team as a code owner October 1, 2024 14:59
@ivanahuckova
Copy link
Member

@ashharrison90 let me know if I should merge and do a release. 🙂

@ashharrison90
Copy link
Contributor Author

@ivanahuckova yes please! I was gonna ask about releasing

@ivanahuckova ivanahuckova merged commit d0c76e4 into main Oct 2, 2024
2 checks passed
@ivanahuckova ivanahuckova deleted the ash/sql-editor-types branch October 2, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanahuckova ivanahuckova ivanahuckova approved these changes

Assignees

@ashharrison90 ashharrison90

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashharrison90 @ivanahuckova