Create IsDownstreamHTTPError method and add error source middleware #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanahuckova
requested review from
wbrowne,
marefr and
andresmgot
and removed request for
a team
ivanahuckova
changed the title
ivanahuckova
changed the title
|
Maybe moving as much as possible for now to https://github.com/grafana/grafana-plugin-sdk-go/tree/main/experimental/errorsource to workaround cyclic dependency? Or don't you want to change https://github.com/grafana/grafana-plugin-sdk-go/blob/main/experimental/errorsource/error_source_middleware.go? |
ivanahuckova
changed the title
|
@ivanahuckova Opened an alternative I would like to explore #1106. Found it too hard to suggest those changes within this PR, sorry. We'll see if that allows to keep backward compatibility and in that case I think it's an interesting idea 🙏 |
|
Closed in favour of #1102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
backend.IsDownstreamHTTPErrormethod that can be used by plugins to check if returned HTTP error is downstreamThere was an issue with circular dependencies. I initially tried to move some stuff to
backend/error_source.goorbackend/experimental/errorsource, but none of these can be imported in http client, because:backendimportshttpclientand therefore we can't importbackendinhttpclientexperimental/errorsourceimports bothbackendandhttpclientBut then landed with the current solution. Let me know what do you think.