Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace @grafana/experimental with @grafana/plugin-ui #1922

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

ivanahuckova
Copy link
Member

This PR replaces @grafana/experimental which we want to deprecate with @grafana/plugin-ui. Data source uses couple of components from these packages, but they are all in ConfigEditor.tsx file. They are the same in @grafana/experimental and @grafana/plugin-ui, with 1 exception - the Stack component is EditorStack in @grafana/plugin-ui. To verify, I recommend:

  • run this branch of plugin
  • open data source config page
  • make sure that config section and data source description look the same

left side is this branch, right side is main:

image image image

@ivanahuckova ivanahuckova requested a review from a team as a code owner November 26, 2024 15:56
Copy link
Member

@zoltanbedi zoltanbedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ivanahuckova ivanahuckova merged commit 3fa881d into main Nov 28, 2024
4 checks passed
@ivanahuckova ivanahuckova deleted the ivana/deprecate-experimental branch November 28, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants