Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tempo-distributed] DOCS fix typos #3027

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[tempo-distributed] DOCS fix typos #3027

wants to merge 7 commits into from
+12 −12

Conversation

mattclegg
Copy link
Contributor

Update TYPOs in DOCS

@mattclegg mattclegg changed the title DOCS fix tempo-distributed [tempo-distributed] DOCS fix typos Mar 15, 2024
krajorama
krajorama requested changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mattclegg,

please review the https://github.com/mattclegg/grafana--helm-charts/blob/DOCS-fix-tempo-distributed/CONTRIBUTING.md guideline. Signing commits is required and also a version bump (on patch level in this case, e.g. 1.9.1->1.9.2), which in turn implies running helm-docs to update the README of the chart.

It's not stated there, but the automation will also refuse PRs that change more than one chart, so I'd advise to move the changes to the tempo chart from #2791 here in this PR.

regards, krajo
please direct mention me (@krajorama ) in reply, otherwise I can miss notifications - I get a tonne

@mattclegg mattclegg force-pushed the DOCS-fix-tempo-distributed branch 2 times, most recently from 921b379 to 0dce02d Compare May 14, 2024 15:22
@mattclegg
Copy link
Contributor Author

Ok @krajorama

Rebased/signed & cherry-picked relevant changes to this PR.

@mattclegg mattclegg mentioned this pull request May 14, 2024
Closed
@mattclegg mattclegg requested a review from krajorama May 22, 2024 12:06
@mattclegg
Copy link
Contributor Author

Merged upstream (again) @krajorama

Sheikh-Abubaker
Sheikh-Abubaker reviewed Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@Sheikh-Abubaker Sheikh-Abubaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! @mattclegg, could you please address the CI lint errors ?

Sheikh-Abubaker
Sheikh-Abubaker reviewed Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@Sheikh-Abubaker Sheikh-Abubaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattclegg could you please address failed checks ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sheikh-Abubaker Sheikh-Abubaker Sheikh-Abubaker left review comments

@mapno mapno Awaiting requested review from mapno mapno is a code owner

@swartz-k swartz-k Awaiting requested review from swartz-k swartz-k is a code owner

@BitProcessor BitProcessor Awaiting requested review from BitProcessor BitProcessor is a code owner

@faustodavid faustodavid Awaiting requested review from faustodavid faustodavid is a code owner

@krajorama krajorama Awaiting requested review from krajorama

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattclegg @krajorama @Sheikh-Abubaker @zanhsieh