[tempo] set unique cluster_label for tempo memberlist #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hobbsh
requested review from
dgzlopes,
swartz-k,
BitProcessor and
faustodavid
as code owners
|
A similar patch to mimir and loki should be made as well ( guessing separate pr?). I ran into an issue in my cluster where loki and mimir pods were seeing each others rings and causing all sorts of problems ( the loki app would not even start up correctly it just failed with strange errors ) Our fix was to set this cluster_label to a unique value for each of the 3 apps. When the pods restarted they correctly were ignored and the clusters formed happily |
|
any news on this feature ? |
Signed-off-by: Wylie Hobbs <[email protected]>
Signed-off-by: Wylie Hobbs <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
joe-elliott
force-pushed
the
unique-cluster-label-tempo
branch
from
4ccd0c3
to
a536dad
Compare
joe-elliott
approved these changes
Nov 6, 2024
zalegrala
approved these changes
Nov 6, 2024
Sheikh-Abubaker
approved these changes
Nov 6, 2024
|
Thanks @hobbsh! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing grafana/tempo#2766 where Loki/Tempo ingesters can join each other's ring because cluster_label seems to be defaulted to something common to both components. This change should mitigate the issue in the future.