[tempo-distributed] add persistentVolumeClaimRetentionPolicy for ingester #3419
+1,237
−1,286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pohldk
requested review from
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor and
faustodavid
as code owners
|
|
pohldk
changed the title
pohldk
force-pushed
the
fix/tempoIngesterPVC
branch
from
bb9afbb
to
aff3f52
Compare
Co-authored-by: Joseph Petersen <[email protected]> Signed-off-by: Michael Pohl <[email protected]>
pohldk
force-pushed
the
fix/tempoIngesterPVC
branch
from
aff3f52
to
2da94f2
Compare
Sheikh-Abubaker
approved these changes
Nov 12, 2024
|
Hey @pohldk, could you please bump the chart version to |
pohldk
force-pushed
the
fix/tempoIngesterPVC
branch
from
a512612
to
b282270
Compare
Signed-off-by: Michael Pohl <[email protected]>
pohldk
force-pushed
the
fix/tempoIngesterPVC
branch
from
b282270
to
992683e
Compare
pohldk
requested review from
torstenwalter,
zanhsieh,
unguiculus,
Whyeasy,
jkroepke,
maorfr,
Xtigyro and
a team
as code owners
|
@Sheikh-Abubaker |
|
Please create a distinct PR for each chart. The CI and approval process is not designed for PR over multiple charts. |
|
Please reopen, clearly a mistake @jkroepke we simply need to only run helmdocs on tempo. My bad. |
|
It seems like you do a force-push with prevents a reopen.
Please create a new PR, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added to Loki distributed chart but would be useful for tempo distributed chart as well.