output/cloudv2: Return empty string instead of "unknown" in rmCollector

grafana · Jul 4, 2023 · 3291b98 · 3291b98
1 parent 6137c5e
commit 3291b98
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/output/cloud/expv2/collect.go b/output/cloud/expv2/collect.go
@@ -251,7 +251,7 @@ func (c *rmCollector) getStringTagFromTrail(trail *httpext.Trail, key string) st
 		return tag
 	}
 
-	return "unknown"
+	return ""
 }
 
 func (c *rmCollector) getIntTagFromTrail(trail *httpext.Trail, key string) int64 {

diff --git a/output/cloud/expv2/collect_test.go b/output/cloud/expv2/collect_test.go
@@ -408,8 +408,8 @@ func Test_requestMetadatasCollector_CollectRequestMetadatas_FiltersAndStoresHTTP
 		TraceID:        "test-trace-id-3",
 		Start:          time.Unix(19, 0),
 		End:            time.Unix(20, 0),
-		TestRunLabels:  insights.TestRunLabels{ID: 1337, Scenario: "unknown", Group: "unknown"},
-		ProtocolLabels: insights.ProtocolHTTPLabels{URL: "unknown", Method: "unknown", StatusCode: 0},
+		TestRunLabels:  insights.TestRunLabels{ID: 1337, Scenario: "", Group: ""},
+		ProtocolLabels: insights.ProtocolHTTPLabels{URL: "", Method: "", StatusCode: 0},
 	})
 }