HTTP/3 support for k6 #3507
HTTP/3 support for k6 #3507
Conversation
There was a problem hiding this comment.
Hey @bandorko,
thanks for your contribution 🎉 I appreciate the fact you want to discuss with us the vision of the new API.
As we always suggest and similar to the process we use for building built-in modules, the process for including a new API is to have an extension where we start gathering feedback and usage—you already did it 🤝
When it gets enough traction to justify being included in the core then we start the process.
However, regarding the HTTP proposal. We already have internally the plan to create a new HTTP module, and we added a new design doc explaining our vision around it. So, it sounds like a better approach if an eventual new protocol is implemented following the design we described there.
Regarding the HTTP3 version, the Go team is working on supporting native in Go the 3rd version of the HTTP protocol. Considering it, I think it makes sense to wait for this release before including it directly into the core. In the meantime, the Core team and the community can continue to experiment with other libraries in the extension.
| HTTP3ReqDurationName = "http3_req_duration" | ||
| // HTTP3ReqSendingName is the name of the HTTP3ReqSending metric. | ||
| HTTP3ReqSendingName = "http3_req_sending" | ||
| // HTTP3ReqWaitingName is the name of the HTTP3ReqWaiting metric. | ||
| HTTP3ReqWaitingName = "http3_req_waiting" | ||
| // HTTP3ReqReceivingName is the name of the HTTP3ReqReceiving metric. | ||
| HTTP3ReqReceivingName = "http3_req_receiving" | ||
| // HTTP3ReqTLSHandshakingName is the name of the HTTP3ReqTLSHandshaking metric. | ||
| HTTP3ReqTLSHandshakingName = "http3_req_tls_handshaking" | ||
| // HTTP3ReqConnectingName is the name of the HTTP3ReqConnecting metric. | ||
| HTTP3ReqConnectingName = "http3_req_connecting" | ||
| // HTTP3ReqsName is the name of the HTTP3Reqs metric. | ||
| HTTP3ReqsName = "http3_reqs" |
There was a problem hiding this comment.
I don't think we need to define new metrics. We could reuse the already defined for the current HTTP module, of course, the proto tag should be different.
|
I fully align with @codebien points 🙇🏻 |
What?
HTTP/3 support for k6
Why?
This is a proposal for implementing HTTP/3 support for K6. I know that it is incomplete (e.g.: there are no test), but I'm really interested in your thoughts on this approach. It uses a ConnectionTracker to collect the metrics about the communication.
I also created it as an extension (https://github.com/bandorko/xk6-http3), but because its code is mostly copied from the k6 source, I thought that HTTP/3 implementation would have a better place in the k6 repository.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)
#238