Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 1.8.4 of the browser module #3966

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Update to 1.8.4 of the browser module #3966

merged 1 commit into from
Sep 24, 2024

Conversation

ankur22
Copy link
Contributor

@ankur22 ankur22 commented Sep 24, 2024 •
edited
Loading

What?

Contains a fix to prevent a goroutine from hanging around.

Why?

Avoids having to force abort the test if it seems to hang.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

grafana/xk6-browser#1437

@ankur22
Update to 1.8.4 of the browser moduler
0f4dbb9 
Contains a fix to prevent a goroutine from hanging around.
@ankur22 ankur22 requested a review from a team as a code owner September 24, 2024 10:40
@ankur22 ankur22 requested review from mstoykov and olegbespalov and removed request for a team September 24, 2024 10:40
@olegbespalov olegbespalov added the dependencies Pull requests that update a dependency file label Sep 24, 2024
@olegbespalov olegbespalov added this to the v0.54.0 milestone Sep 24, 2024
@mstoykov mstoykov merged commit 0b14836 into master Sep 24, 2024
22 checks passed
@mstoykov mstoykov deleted the update/browser-1.8.4 branch September 24, 2024 13:29
@ankur22 ankur22 changed the title Update to 1.8.4 of the browser moduler Update to 1.8.4 of the browser module Sep 25, 2024
@BrewTestBot BrewTestBot mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstoykov mstoykov mstoykov approved these changes

@oleiade oleiade oleiade approved these changes

@olegbespalov olegbespalov olegbespalov approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
v0.54.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ankur22 @mstoykov @oleiade @olegbespalov