- 
                Notifications
    
You must be signed in to change notification settings  - Fork 3.8k
 
feat(storage): AWS backend using thanos.io/objstore #11221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fd69ec7    to
    4bc8466      
    Compare
  
    | 
          
 Trivy scan found the following vulnerabilities: 
  | 
    
b8f05d5    to
    41982d2      
    Compare
  
    674c73f    to
    4c2859b      
    Compare
  
    e0cfa6e    to
    4337f02      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On pkg/storage/bucket/client.go we should also uncomment lines 88 to 90.
Co-authored-by: Joao Marcal <[email protected]>
| // RegisterFlagsWithPrefix registers the flags for s3 storage with the provided prefix | ||
| func (cfg *HTTPConfig) RegisterFlagsWithPrefix(prefix string, f *flag.FlagSet) { | ||
| cfg.Config.RegisterFlagsWithPrefix(prefix+"s3.", f) | ||
| f.DurationVar(&cfg.IdleConnTimeout, prefix+"s3.http.idle-conn-timeout", 90*time.Second, "The time an idle connection will remain idle before closing.") | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| f.DurationVar(&cfg.IdleConnTimeout, prefix+"s3.http.idle-conn-timeout", 90*time.Second, "The time an idle connection will remain idle before closing.") | |
| s3prefix := prefix + "s3." | |
| f.DurationVar(&cfg.IdleConnTimeout, s3prefix+"http.idle-conn-timeout", 90*time.Second, "The time an idle connection will remain idle before closing.") | 
| f.IntVar(&cfg.MaxIdleConns, prefix+"s3.max-idle-connections", 100, "Maximum number of idle (keep-alive) connections across all hosts. 0 means no limit.") | ||
| f.IntVar(&cfg.MaxIdleConnsPerHost, prefix+"s3.max-idle-connections-per-host", 100, "Maximum number of idle (keep-alive) connections to keep per-host. If 0, a built-in default value is used.") | ||
| f.IntVar(&cfg.MaxConnsPerHost, prefix+"s3.max-connections-per-host", 0, "Maximum number of connections per host. 0 means no limit.") | ||
| cfg.TLSConfig.RegisterFlagsWithPrefix(prefix, f) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also pass the prefix + "s3." as prefix here.
Co-authored-by: Ashwanth Goli <[email protected]> (cherry picked from commit b872246)
What this PR does / why we need it:
This PR adds support to use the thanos.io/objstore backend for the AWS provider for all components excluding the Ruler since it's similar to the work done in #11132.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
.httpwhile others weren't)CLI Table
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR