[bloom-compactor] Clean up work to create blooms #11591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line did not contain a key value pair Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
|
Trivy scan found the following vulnerabilities:
|
paul1r
approved these changes
Jan 5, 2024
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
**What this PR does / why we need it**: This PR is the result of debugging sprint on bloom-compactor on a dev cell. With these changes, compactor now can create and upload blooms and relevant meta files from scratch. - Queries tsdb correctly with empty matchers to get all series - Seeks to the beginning of the bloom data file before uploading - Adds uuid strings to local file name, as checksum is not available at the time of directory creation - Creates meta object with all fields populated - Additional logging edit: confirmed that it runs as expected in the dev cell. --------- Signed-off-by: Christian Haudum <[email protected]> Co-authored-by: Christian Haudum <[email protected]> Co-authored-by: Paul Rogers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is the result of debugging sprint on bloom-compactor on a dev cell.
With these changes, compactor now can create and upload blooms and relevant meta files from scratch.
edit: confirmed that it runs as expected in the dev cell.