Add name labels and modify runtime cfg name
#12291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanGuedes
force-pushed
the
change-runtimeconfig
branch
from
0a82135
to
e005f04
Compare
DylanGuedes
changed the title
name labelsname labels and modify runtime cfg name
| @@ -184,7 +184,7 @@ spec: | |||
| {{- include "loki.configVolume" . | nindent 10 }} | |||
| - name: runtime-config | |||
| configMap: | |||
| name: {{ template "loki.fullname" . }}-runtime | |||
| name: {{ template "loki.name" . }}-runtime | |||
There was a problem hiding this comment.
The configmap creation isn't updated as far as I can see. So how will this match that?
There was a problem hiding this comment.
that's the issue - the configmap name is actually {{ template "loki.name" . }}-runtime. We'd have to either, modify it to be .fullname and update the other places to use .fullname, or just change these few pieces to stay as .name
There was a problem hiding this comment.
it looks like the runtime configmap is created with loki.name already?
slim-bean
approved these changes
Mar 21, 2024
slim-bean
merged commit 38d8b62
into
ewelch-distributed-helm-chart
8 of 12 checks passed
DylanGuedes
added a commit
that referenced
this pull request
Mar 21, 2024
This reverts commit 38d8b62.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
namelabel to all components (ingesters already have this)fullName(the other components only usename)Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR