Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dskit and thanos/objstore #13998

Merged
merged 4 commits into from
Aug 29, 2024
Merged

chore: update dskit and thanos/objstore #13998

merged 4 commits into from
Aug 29, 2024

Conversation

na--
Copy link
Member

@na-- na-- commented Aug 29, 2024

What this PR does / why we need it:

This is mostly to include grafana/dskit#580, which updates the grpc dependency to v1.66.0. That update needed to be in dskit because it contains a slightly breaking change with the removal of RecvBufferPool .

Similarly, the current github.com/thanos-io/objstore version has the same reliance on RecvBufferPool and incompatibility with grpc v1.66.0. Updating it to the latest main fixes that because it includes thanos-io/objstore#133.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@na-- na-- requested a review from a team as a code owner August 29, 2024 13:11
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Aug 29, 2024
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@na-- na-- merged commit f9824b7 into main Aug 29, 2024
61 checks passed
@na-- na-- deleted the ned/update-dskit branch August 29, 2024 14:57
pascal-sochacki pushed a commit to pascal-sochacki/loki that referenced this pull request Aug 29, 2024
pascal-sochacki pushed a commit to pascal-sochacki/loki that referenced this pull request Aug 29, 2024
pascal-sochacki pushed a commit to pascal-sochacki/loki that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants