feat: Add Proxy to Alertmanager client #14007
Open
+73
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I'm not quite sure if this is all i need to do... will test tomorrow and update the docs Is adding this a change to Configuration parameters?
Edit: seems to work |
pascal-sochacki
changed the title
github-actions
bot
added
the
type/docs
|
should i add the option to add the config via cli flags? |
|
Would it be possible to squash this into a single commit? There are a lot of commits like |
pascal-sochacki
force-pushed
the
main
branch
from
046d127
to
b9aac02
Compare
|
clicked the wrong button in the gh ui, there you go! --Or should i squash my 4 commits also into one?-- Done |
pascal-sochacki
force-pushed
the
main
branch
9 times, most recently
from
dac9657
to
fe2285d
Compare
|
Hey @grobinson-grafana, can you please look at the change and provide feedback? |
pascal-sochacki
force-pushed
the
main
branch
from
fe2285d
to
027bdb5
Compare
Signed-off-by: Pascal Sochacki <[email protected]>
pascal-sochacki
force-pushed
the
main
branch
from
027bdb5
to
3212a1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I added the option to add a proxy to the alertmanager client. My use use-case is to send out alerts to an external alertmanager which sits behind a http proxy
Which issue(s) this PR fixes:
Fixes #14009
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR