fix(detected_fields): return parsed labels when parsers are passed
#14047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtk-grafana
reviewed
Sep 4, 2024
| @@ -1075,6 +1076,8 @@ func (q *SingleTenantQuerier) DetectedFields(ctx context.Context, req *logproto. | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| // just incject the header to categorize labels | |||
There was a problem hiding this comment.
Suggested change
| // just incject the header to categorize labels | |
| // just inject the header to categorize labels |
gtk-grafana
changed the title
detected_fields: return parsed labels when parsers are passeddetected_fields): return parsed labels when parsers are passed
|
|
trevorwhitney
approved these changes
Sep 4, 2024
grafanabot
pushed a commit
that referenced
this pull request
Sep 4, 2024
…14047) Co-authored-by: Galen Kistler <[email protected]> Co-authored-by: Trevor Whitney <[email protected]> (cherry picked from commit aa1ac99)
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
detected_fieldsAPI accepts a full "logQL" query to be passed. This includes parsers. If parsers were passed, theSelectLogsstatement would parse labels into thestreamLabelsproperty. That would then cause thedetected_fieldslogic to run the "detection" logic again and append_extractedto all parsed labels.This PR changes the behavior: if parsed labels are returned by
SelectLogs, the API does not try to be smart and to parse again, but just return structuredmetadata and parsed labels. Theparsersreturned in that case will be the parsers used in the query.