Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add info about remotewrite client config in ruler (backport release-3.0.x) #14699

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Oct 31, 2024

Backport b7ac5b4 from #14401


What this PR does / why we need it:
When setting up a remote write client for recording rules, I found it unclear what RemoteWriteConfig referred to. After checking the code, I realised it was actually a Prometheus remote write configuration. Adding this clarification in the documentation will make it easier for others to understand the setup without needing to dive into the code.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.

@loki-gh-app loki-gh-app bot requested a review from a team as a code owner October 31, 2024 17:17
@loki-gh-app loki-gh-app bot added backport size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Oct 31, 2024
@loki-gh-app loki-gh-app bot requested a review from JStickler October 31, 2024 17:17
@JStickler JStickler merged commit b859eb5 into release-3.0.x Oct 31, 2024
53 of 56 checks passed
@JStickler JStickler deleted the backport-14401-to-release-3.0.x branch October 31, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants