Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blooms): Skip multi-tenant TSDBs during bloom planning #14770

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

salvacorts
Copy link
Contributor

What this PR does / why we need it:
Tables that have not been fully compacted yet will have multi-tenant TSDBs for which the tenant is "" (coming tsdbStore.UsersForPeriod and indexStorageClient.ListFiles)

In this PR we update the planner to skip these multi-tenant TSDBs.

I though about fixing this at the indexStorageClient.ListFiles level but I think it's relatively risky given it's is used in the compactor.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts changed the title Skip multi-tenant TSDBs during bloom planning fix(blooms): Skip multi-tenant TSDBs during bloom planning Nov 5, 2024
@salvacorts salvacorts marked this pull request as ready for review November 5, 2024 11:54
@salvacorts salvacorts requested a review from a team as a code owner November 5, 2024 11:54
@salvacorts salvacorts merged commit 76d35cc into main Nov 5, 2024
61 checks passed
@salvacorts salvacorts deleted the salvacorts/skip-empty-tenants branch November 5, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants