Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blooms): Do not restart builders when planner disconnects #14783

Merged

Conversation

salvacorts
Copy link
Contributor

@salvacorts salvacorts commented Nov 6, 2024

What this PR does / why we need it:

Before this PR, when the planner restarted, all builders errored and restarted as well. This happened becvause even though we had a backoff mechanism, it was not reset when we could connect at least once succesfully.

This PR fixes this so builders just retry connecting to the planner again. We handle the EOF error we get when the planner disconnects to reset the backoff and start again.

Here's an example:

While the planner is down, there are no restarts
image

But we do print errors
image

We did this test using this backoff config:

bloom_build+: {
  builder+: {
    backoff_config+: {
      min_period: '1s',
      max_period: '1m',
    },
  },
},

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts marked this pull request as ready for review November 6, 2024 11:52
@salvacorts salvacorts requested a review from a team as a code owner November 6, 2024 11:52
Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable!

@salvacorts salvacorts merged commit 7669385 into main Nov 6, 2024
59 checks passed
@salvacorts salvacorts deleted the salvacorts/do-not-restart-builders-when-planner-restarts branch November 6, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants