Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove initialization of RF-1 components from pkg/loki #14787

Merged

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Nov 6, 2024

What this PR does / why we need it:

This commit removes initialization of RF-1 components from pkg/loki so we can start to delete old RF-1 code.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@grobinson-grafana grobinson-grafana requested a review from a team as a code owner November 6, 2024 10:19
@grobinson-grafana grobinson-grafana changed the title Remove initialization of RF-1 components from pkg/loki chore: remove initialization of RF-1 components from pkg/loki Nov 6, 2024
@grobinson-grafana grobinson-grafana force-pushed the grobinson/remove-initialization-of-rf1-components branch from c08842e to 7c0ef90 Compare November 6, 2024 13:15
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 6, 2024
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Nov 6, 2024
@grobinson-grafana grobinson-grafana force-pushed the grobinson/remove-initialization-of-rf1-components branch 3 times, most recently from 7497745 to 583f232 Compare November 6, 2024 14:10
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grobinson-grafana grobinson-grafana force-pushed the grobinson/remove-initialization-of-rf1-components branch from 583f232 to 9b50634 Compare November 6, 2024 14:50
@grobinson-grafana grobinson-grafana merged commit 9f6ba80 into main Nov 6, 2024
60 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/remove-initialization-of-rf1-components branch November 6, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants