Skip to content

feat(disble fmt): Allow disabling logfmt parsing #18107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ajay-Satish-01
Copy link

What this PR does / why we need it:
Allow completely disabling logfmt parsing.

Which issue(s) this PR fixes:
Fixes #17507

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@Ajay-Satish-01 Ajay-Satish-01 requested a review from a team as a code owner June 14, 2025 21:35
@CLAassistant
Copy link

CLAassistant commented Jun 14, 2025

CLA assistant check
All committers have signed the CLA.

@chaudum
Copy link
Contributor

chaudum commented Jun 18, 2025

@Ajay-Satish-01 Could you elaborate on why you would want to disable a specific LogQL feature? What problem does it solve?

@Ajay-Satish-01
Copy link
Author

@Ajay-Satish-01 Could you elaborate on why you would want to disable a specific LogQL feature? What problem does it solve?

From my tests, it was contributing to false positives and misinterpreting Apache/Nginx logs as logfmt format. Please correct me if I am wrong.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow disabling logfmt parsing
3 participants