Bump to latest mimir-prometheus #10383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version synced here: grafana/mimir-prometheus#818
Fix everything related to prometheus/prometheus#15686 We don't support `double_exponential_smoothing` and `predict_linear`, but `deriv` needs to emit a new annotation
julienduchesne
requested review from
stevesg,
grafanabot and
a team
as code owners
jhesketh
reviewed
Jan 9, 2025
ArthurSens
approved these changes
Jan 9, 2025
Co-authored-by: Arthur Silva Sens <[email protected]>
aknuds1
approved these changes
Jan 9, 2025
2 tasks
julienduchesne
added a commit
that referenced
this pull request
Jan 10, 2025
Same fix as prometheus/prometheus#15711 and similar to what was done during the last sync: #10383
julienduchesne
added a commit
that referenced
this pull request
Jan 10, 2025
* Update to latest mimir-prometheus Also implement new rule concurrency interface from prometheus/prometheus#15681 * MQE: Pull new functions test and fix _over_time functions Same fix as prometheus/prometheus#15711 and similar to what was done during the last sync: #10383 * Linting * MQE: Use `.Any()` as suggested in PR * Add CHANGELOG * Remove sequentialRules, not needed A nil slice will run rules sequentially * Address PR comments * Add test to check that group isn't mutated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version synced here: grafana/mimir-prometheus#818
The only problem I had was with this PR from prometheus: prometheus/prometheus#15686. I had to fix some tests and implement the same fix in our MQE
derivfunction: cd4912eWhat this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.