Update dskit and mimir-prometheus #8632
Conversation
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
| @@ -28,6 +28,8 @@ var NonParallelFuncs = []string{ | |||
| "absent", | |||
| "absent_over_time", | |||
| "histogram_quantile", | |||
| "limitk", | |||
There was a problem hiding this comment.
I think limitk is safe to parallelize, just like topk/bottomk.
Maybe it's worth creating a new good-first-issue issue and let someone send a PR adding some tests for it?
There was a problem hiding this comment.
Topk and bottok are not parallelizeable as well (see details in this internal ticket).
Why they're not mentioned here? Right now I don't remember all implementation details of how these functions are guaranteed not to be parallelized. I will investigate it further, but will not block this PR on this.
woOT!, thanks @pracucci 🎉 |
What this PR does
In this PR I'm updating dskit and mimir-prometheus to get:
In this PR we're also introducing the new experimental PromQL functions
limitk()andlimit_ratio()done by @jjo. I've marked them as non shardable, just because I didn't want to spend an effort right now to brainstorm whether they're shardable or not and then add tests on them (they're disabled by default). We can revisit this later.Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.