Skip to content

Commit

Permalink
Rename notify whole Slack channel (#4577)
Browse files Browse the repository at this point in the history
# What this PR does
rename "Notify whole Slack channel" escalation step into "Escalate to
all slack channel members"

## Which issue(s) this PR closes

Closes #4373

<!--
*Note*: if you have more than one GitHub issue that this PR closes, be
sure to preface
each issue link with a [closing
keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue).
This ensures that the issue(s) are auto-closed once the PR has been
merged.
-->

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
  • Loading branch information
brojd authored Jun 25, 2024
1 parent c39dd8b commit 5ca0d13
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
4 changes: 2 additions & 2 deletions docs/sources/configure/escalation-chains-and-routes/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ from an on-call schedule.
* `Notify all users from a team` - send a notification to all users in a team.
* `Resolve incident automatically` - resolve the alert group right now with status
`Resolved automatically`.
* `Notify whole slack channel` - send a notification to the users in the slack channel. These users will be notified
* `Escalate to all Slack channel members` - send a notification to the users in the slack channel. These users will be notified
via the method configured in their user profile.
* `Notify Slack User Group` - send a notification to each member of a slack user group. These users will be notified
via the method configured in their user profile.
Expand All @@ -97,7 +97,7 @@ Useful when you want to get escalation only during working hours
passes some threshold
* `Repeat escalation from beginning (5 times max)` - loop the escalation chain

> **Note:** Both "**Notify whole Slack channel**" and "**Notify Slack User Group**" will filter OnCall registered users
> **Note:** Both "**Escalate to all Slack channel members**" and "**Notify Slack User Group**" will filter OnCall registered users
matching the users in the Slack channel or Slack User Group with their profiles linked to their Slack accounts (ie. users
should have linked their Slack and OnCall users). In both cases, the filtered users satisfying the criteria above are
notified following their respective notification policies. However, to avoid **spamming** the Slack channel/thread,
Expand Down
2 changes: 1 addition & 1 deletion docs/sources/manage/notify/slack/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ and users:
Once your Slack integration is configured you can configure Escalation Chains to notify via Slack messages for alerts
in Grafana OnCall.

There are two Slack notification options that you can configure into escalation chains, notify whole Slack channel and
There are two Slack notification options that you can configure into escalation chains, escalate to all Slack channel members and
notify Slack user group:

1. In Grafana OnCall, navigate to the **Escalation Chains** tab then select an existing escalation chain or
Expand Down
5 changes: 4 additions & 1 deletion engine/apps/alerts/models/escalation_policy.py
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,10 @@ class EscalationPolicy(OrderedModel):
),
STEP_FINAL_RESOLVE: ("Resolve alert group automatically", "Resolve alert group automatically"),
# Slack
STEP_FINAL_NOTIFYALL: ("Notify whole Slack channel", "Notify whole Slack channel"),
STEP_FINAL_NOTIFYALL: (
"Escalate to all Slack channel members (use with caution)",
"Escalate to all Slack channel members (use with caution)",
),
STEP_NOTIFY_GROUP: (
"Start {{importance}} notification for everyone from Slack User Group {{slack_user_group}}",
"Notify Slack User Group",
Expand Down

0 comments on commit 5ca0d13

Please sign in to comment.