Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.3.42 #3120

Merged
merged 3 commits into from
Oct 4, 2023
Merged

v1.3.42 #3120

merged 3 commits into from
Oct 4, 2023

Conversation

matiasb
Copy link
Contributor

@matiasb matiasb commented Oct 4, 2023

No description provided.

joeyorlando and others added 3 commits October 4, 2023 09:04
# What this PR does

Since we now have a Mailslurp account we can start running this test. At
the moment it is only run 1x daily on a GitHub Actions cron (to avoid
incurring costs; [it is
skipped](https://github.com/grafana/oncall/blob/dev/.github/workflows/linting-and-tests.yml#L317)
via a Playwright "[test annotation
filter](https://github.com/grafana/oncall/blob/dev/grafana-plugin/package.json#L14-L15)").

`MAILSLURP_API_KEY` repo secret has already been updated.

Closes #2693
#3110)

Related to grafana/oncall-private#2191

This will also allow plugin to get shift name and type from the
filter_events API, without needing to get details for each involved
shift in the user's on-call summary timeline.
@matiasb matiasb requested review from a team October 4, 2023 19:02
@matiasb matiasb added the pr:no public docs Added to a PR that does not require public documentation updates label Oct 4, 2023
@matiasb matiasb merged commit 1f725d8 into main Oct 4, 2023
35 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants