conditionally enable searching for alert groups via env var #4287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add this solution to Incident's Public API? If it is possible |
joeyorlando
approved these changes
Apr 26, 2024
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Failure
joeyorlando
changed the title
joeyorlando
changed the title
joeyorlando
added
pr:no public docs
|
@sreway if you don't mind address the linting CI errors I can go ahead and merge this! (run |
Co-authored-by: Joey Orlando <[email protected]>
This solution will not work with the public API. You can create a feature request to extend the filtering of alert groups. |
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
maskin25
reviewed
Apr 29, 2024
|
@maskin25 are things okay from your point of view? |
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
# What this PR does Only validate live settings in `AVAILABLE_NAMES` to avoid issues when a live setting is renamed (one of the settings was renamed in #4287 earlier) ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] Added the relevant release notes label (see labels prefixed w/ `release:`). These labels dictate how your PR will show up in the autogenerated release notes.
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
# What this PR does re-enables the search for alert groups ## Which issue(s) this PR closes Closes #2232 <!-- *Note*: if you have more than one GitHub issue that this PR closes, be sure to preface each issue link with a [closing keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue). This ensures that the issue(s) are auto-closed once the PR has been merged. --> ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] Added the relevant release notes label (see labels prefixed w/ `release:`). These labels dictate how your PR will show up in the autogenerated release notes. --------- Co-authored-by: Joey Orlando <[email protected]> Co-authored-by: Joey Orlando <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
re-enables the search for alert groups
Which issue(s) this PR closes
Closes #2232
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.