-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make rotation start and rotation end take timezone into consideration #4481
Conversation
88a2a25
to
e42bc86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe worthwhile adding some unit tests for some of the time related utility functions, wdyt?
I can see the issue when you create Rotation that starts before / after DST change comparing to current time: Screen.Recording.2024-06-07.at.07.01.41.mov |
Another issue is that the day jumps to previous day if you select date that is before / after DST change: Screen.Recording.2024-06-07.at.07.05.53.movScreen.Recording.2024-06-07.at.07.15.18.mov |
I can see the following issues:
Screen.Recording.2024-06-11.at.10.22.15.mov
Screen.Recording.2024-06-11.at.10.26.47.mov
Screen.Recording.2024-06-11.at.10.33.18.mov
Screen.Recording.2024-06-11.at.01.43.40.mov |
Tests will be added separately as there's quite many cases to be handled and verified. before dst/during dst/after, switching from one period to another, changing the timezone etc |
6438aa1
to
ad05205
Compare
What this PR does
Related to #4428